GSA-TTS / usagov-benefits-eligibility

Benefits eligibility estimator tool for USAGov.
23 stars 5 forks source link

check application for missing content #878

Closed nehemiah-abuga closed 1 year ago

nehemiah-abuga commented 1 year ago

PR Summary

This PR if for tests on death of a loved one, disability and retirement page for both English and Spanish to validate missing content for text by checkbox labels. I am validating to ensure the labels do not contain "criteria." or ".label"

Related Github Issue

Type of change

Detailed Testing steps

Pull the branch to local Run npm run cypress:run_chrome and verify all tests pass Run nnpx cypress open and verify tall tests pass

github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
scottqueen-bixal commented 1 year ago

These all work, but we need to take a more DRY approach that will help us to scale locale testing easier. We only need one test for this, rather than multiple files of the same test.

Let's update to include the following:

github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```