GSA-TTS / usagov-benefits-eligibility

Benefits eligibility estimator tool for USAGov.
23 stars 5 forks source link

add links tests #890

Closed nehemiah-abuga closed 1 year ago

nehemiah-abuga commented 1 year ago

PR Summary

The PR is add tests to validate 2XX and #XX status response for the various links within

Death of a loved one English and Spanish page Disability English and Spanish page Retirement English and Spanish page

Related Github Issue

Type of change

Detailed Testing steps

Run npm run cypress:run_chrome and verify all tests pass including the added links tests Run npx cypress open and verify the links tests pass

github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
nehemiah-abuga commented 1 year ago

@scottqueen-bixal - I have made the updates

scottqueen-bixal commented 1 year ago

let's hold off on putting this in upstream until this ticket is completed https://github.com/orgs/GSA/projects/48/views/10?pane=issue&itemId=30816804

just so we don't have failing tests on all the other work coming in.

github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```
scottqueen-bixal commented 1 year ago

let's hold off on putting this in upstream until this ticket is completed https://github.com/orgs/GSA/projects/48/views/10?pane=issue&itemId=30816804

just so we don't have failing tests on all the other work coming in.

Deciding to move forward based on the recommendation that

....since from QA it is done we can merge into main because the code is doing what it is supposed to do...able to catch the issues

github-actions[bot] commented 1 year ago
Pa11y testing results ``` > usagov-benefits-eligibility@1.2.0 test:pa11y > pa11y http://localhost:3000/ Welcome to Pa11y > Running Pa11y on URL http://localhost:3000/ No issues found! ```