GSA-TTS / usagov-benefits-eligibility

Benefits eligibility estimator tool for USAGov.
22 stars 5 forks source link

Disability page “Concurrent Retirement and Disability Payments (CRDP)” eligibility criteria displaying incorrectly for selected filter option. #949

Closed nehemiah-abuga closed 1 year ago

nehemiah-abuga commented 1 year ago

Description

Disability page “Concurrent Retirement and Disability Payments (CRDP)” eligibility criteria displaying incorrectly for selected filter option.

Steps to reproduce

Select the options in the query https://benefits-tool.usa.gov/disability/?77edd0d=yes&b95c6d4=7-25-1963&8c5fff1=1&2fe2b3a=yes&633dad2=a+member+of+the+National+Guard%2FReserve and validate that the eligibility criteria is displaying correctly

Given “a member of the National Guard/Reserve” option is selected, the eligibility criteria for this option should have a green check mark instead of it being red crossed out.

The same issue is also on the disability Spanish page. For this select “retirado del servicio” option

https://benefits-tool-demo.usa.gov/es/disability/?b95c6d4=7-25-1963&8c5fff1=1&2fe2b3a=s%C3%AD&633dad2=retirado+del+servicio

Actual Results

Image

Image

scottqueen-bixal commented 1 year ago

looks like a simple content update is required

Screenshot 2023-07-26 at 11 13 27 AM Screenshot 2023-07-26 at 11 12 53 AM
diegocob commented 1 year ago

@scottqueen-bixal, I didn't get what the two options were. I understand that the criteria has to match so that it's marked as a green check when it's selected.

scottqueen-bixal commented 1 year ago

assigning to @EnriqueOrt for requirements gathering

diegocob commented 1 year ago

@nehemiah-abuga we had a meeting with @EnriqueOrt and @fongcindy. The UI needs to match the criteria.

  1. In the Disability and Retirement pages, when someone selects “a member of the National Guard/Reserve”, the eligibility criteria for this option should have a green check mark instead of it being red crossed out.

  2. The same on the Disability and Retirement Spanish page. For this select “retirado del servicio” option.

scottqueen-bixal commented 1 year ago

This has been updated and QA'd on our end, ready for final review @EnriqueOrt

EnriqueOrt commented 1 year ago

Reviewed and approved. All information present and threads resolved. Thank you!