search

GSA / 889-tool

Web service for determining 889 compliance of vendors
1 stars 0 forks source link

889 Tool | NASA Recognition #123

Closed rebekahperillo closed 7 months ago

rebekahperillo commented 1 year ago

NASA, as the original creator of the 889 tool, needs to be given more credit on the 889 tool.

https://889.smartpay.gsa.gov/#/

Acceptance Criteria:

klohman commented 1 year ago

Design options

Option 1: Logo in header - left

image

Option 2: Logo in footer

image

Option 3: Logo in header - right aligned

image

rebekahperillo commented 1 year ago

These all look great. Do you mind if I pass them along to Jeff White from OSC to hear his thoughts? Then, I'll pass along to my supervisor for final weigh in.

Does this plan for the team?

Rebekah Knouse Perillo (she/her)

Lead Business Management Specialist

Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

301-938-5257

@.***

Follow the GSA SmartPay program on social media...Tweet with us on Twitter https://twitter.com/GSASmartPayNews and friend us on Facebook https://www.facebook.com/GSASmartPayNews/! [image: image.png]

On Mon, Jul 17, 2023 at 11:25 AM Kristen Lohman @.***> wrote:

Design options Option 1: Logo in footer

[image: image] https://user-images.githubusercontent.com/18366192/253988878-fb7e594b-7604-472a-9878-099e77e5d012.png Option 2: Logo in header - left

[image: image] https://user-images.githubusercontent.com/18366192/253989091-df5aa96c-efdd-4179-9a06-a2f4b05fe5d6.png Option 3: Logo in header - right aligned

[image: image] https://user-images.githubusercontent.com/18366192/253989179-8713f411-cacc-4e6d-9dcf-974686678801.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/889-tool/issues/123, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7Z6HEQ2W6YWSO73UR7XA63XQVKOBANCNFSM6AAAAAA2KQJSXM . You are receiving this because you authored the thread.Message ID: @.***>

JessicaMarine1 commented 1 year ago

Feedback from Jeff White (OSC branding):

Version 1 - not feeling the reverse Star Mark next to the full color NASA logo (and the distance between the two needs to be increased so that there is one full Star Mark between them). The blue of the NASA logo is also getting lost in the background. Since NASA doesn't have a reverse version of their logo we should use our full color version of the Star Mark and make the header of the page white (following our normal guidelines for white bar size found in our branding guidelines).

Version 2 - need to increase the space between the Star Mark and text to allow for one full Star Mark between them

Version 3 - same feedback for text as in v.2 and the mix of one color and full color doesn't work. Change headers background color to white and go full color for both logos.

JessicaMarine1 commented 1 year ago

@klohman please see the comments from Jeff White above. Could you please modify the mockups to match his suggested edits so that I can pass them through Sarah Bryant (OSC) for final comment. ty

klohman commented 1 year ago

Updated

Option 1

image

Option 2

image

Option 3

image

JessicaMarine1 commented 1 year ago

The first part of NASA's Media Usage Guidelines: The NASA Insignia (the blue "meatball" logo), the NASA Logotype (the "worm" logo) and the NASA Seal may not be used for any purpose without explicit permission. These images may not be used by persons who are not NASA employees or on products, publications or web pages that are not NASA-sponsored.

JessicaMarine1 commented 1 year ago

Feedback from Sarah Bryant in OSC:

  1. Use the full USWDS identifier component, including the required links. And it must say "An official website of the U.S. General Services Administration".
  2. Consider the site name and description. The "889 compliance search" title implies a user can enter criteria and get a set of results. But it appears the functionality is actually to check if a specific vendor is 889 compliant.
  3. The "889 Compliance SAM Tool web application" is bureaucratese. A plain language version would be along the lines of "This tool was built by NASA using the sam.gov Entity Management API".
  4. If the site isn't being co-managed with NASA, but has been handed over to GSA to manage, it makes more sense for the partnership information to be in the footer, as presented in option 2.

TLDR:

klohman commented 1 year ago

Regarding the comment on the name of the tool, I noticed the live site has it called "889 Representations Search" (the old wireframes I pulled had the other name).

Here's an updated mockup that more closely matches the live site. This mock also includes:

image

JessicaMarine1 commented 1 year ago

@klohman could you update the light gray footer to:

This tool was built by NASA using the SAM.gov Entity Management API. We encourage input! Please provide feedback and suggestions to gsa_smartpay@gsa.gov

Limitation on Permissible Use of Dun & Bradstreet, Inc. (D&B) Data

Just trying to get it closer to what's on prod and only changing 1st sentence: https://889.smartpay.gsa.gov/#/

klohman commented 1 year ago

@JessicaMarine1 Updated.

image

JessicaMarine1 commented 1 year ago

Update 8/2/2023:

JessicaMarine1 commented 11 months ago

We need to put the GSA footer on the 889 tool regardless of the NASA co-branding decisions, so I'm going to make that another story (#299).

rebekahperillo commented 10 months ago

@JessicaMarine1 @mark-meyer Design approved by NASA! Also are we able to update the light gray portion to have a period after gsa_smartpay@gsa.gov? Thank you!

JessicaMarine1 commented 10 months ago

Please save this work for KL&A :)

JessicaMarine1 commented 9 months ago

@rebekahperillo I believe the scope of this story has changed over time. As a result, I would recommend updating the AC to:

CodyHinze commented 9 months ago

AC has been updated based on @JessicaMarine1's comment above.

Need to get a final version the NASA logo.

CodyHinze commented 9 months ago

NOTE: Because this has an image, we will also need to include an Alt tag on the image that describes the NASA logo.

rebekahperillo commented 9 months ago

@CodyHinze Found the NASA logo! :) If you need anything else, please let me know. Thank you!

Image

CodyHinze commented 8 months ago

The logo above includes the checkerboard background in the image file. Visually, this is identical to the publicly available version on Wikipedia, but we wanted to ensure we are using the correct version. and the version used in the nasa.gov website footer.

SVG - https://upload.wikimedia.org/wikipedia/commons/e/e5/NASA_logo.svg

Official SVG - https://www.nasa.gov/wp-content/themes/nasa/assets/images/nasa-logo.svg

I would recommend we use the version that is currently used on the official nasa.gov site.

rebekahperillo commented 8 months ago

@klohman Hello again! Do you happen to remember which logo file you used when you created the mockup above? Thank you for your help!

klohman commented 8 months ago

@klohman Hello again! Do you happen to remember which logo file you used when you created the mockup above? Thank you for your help!

@rebekahperillo Looks like I saved the original file to my old Macbook. I agree with @CodyHinze though that we should use the version from the official NASA site if that's available for you to pull.

rebekahperillo commented 8 months ago

@klohman Perfect, thank you!

@CodyHinze Please see Kristen's advice. If you have any questions, please let me know.

JennaySDavis commented 8 months ago

#123 Acceptance Criteria

Pass/Fail Description
Implement design changes in footers to match design
Pass 1st sentence in grey footer
Pass Adding attribution & NASA logo in black footer
Pass Add period to the end of the second line in the grey footer: "We encourage input! Please provide feedback and suggestions to gsa_smartpay@gsa.gov. "

Comments/Additional Notes Performance score - This relates to the entire screen performance. I also ran Lighthouse in production, and it was 69. I do know in the QASP that it was noted that the 889 tool may need to meet the 90% standard. A ticket should be created to improve the performance of the 889 tool, and I can attach the report to the ticket that will assist the developers when the ticket is pulled into a sprint.

Criteria Score
Performance 78
Accessibility 100
Best Practices 98
johnbeallgsa commented 8 months ago

@JennaySDavis Let's chat about this Monday. I have a few questions on the Performance. Would you happen to know what the score was before? How can the score be improved now, or does that require a new story? Can the improvement be done before releasing it into production?

The NASA logo and everything else look great, though!

CodyHinze commented 8 months ago

The current production version of the 889 tools home page (https://889.smartpay.gsa.gov/#/) receives the following in Lighthouse.

Criteria Score
Performance 97
Accessibility 100
Best Practices 91

The performance number on the staging environment should only be used as a guide, it may return a false indicator of server performance and load times that are not reflected on production. When I re-ran the same scan on Production 3 times, I received between a 94 and a 98 for performance based on three scans performed a few minutes apart.

Since the changes made in this ticket only include minor changes in the HTML structure in the footer and the addition of a single optimized SVG image, the performance numbers on staging are not a concern.

Please note that there are usability concerns on the Search results screens, including the following:

johnbeallgsa commented 8 months ago

Moving to Done with new enhancement ticket made #146 for a future sprint. Excellent work, team, and thank you for all the explanations.