GSA / 889-tool

Web service for determining 889 compliance of vendors
1 stars 0 forks source link

Improve performance by adding explicit height and width to image elements #146

Open JennaySDavis opened 7 months ago

JennaySDavis commented 7 months ago

When testing https://github.com/GSA/889-tool/issues/123, I found the following performance issue of adding explicit height and width to image elements to increase the performance on the 889 tool. The 889 tool meets GSA performance standards, but this would enhance the performance on the screen when loaded. I've attached the images without explicit height and width.

Image

JennaySDavis commented 1 week ago

#146 Acceptance Criteria

Pass/Fail Description
Pass Improve performance by adding explicit height and width to image elements

Comments/Additional Notes Best Practice scores could improved based on the results from #162

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 100
Accessibility 100
Best Practices 93

Passed 6/26/2024- JSD

johnbeallgsa commented 1 week ago

@JennaySDavis, I see the 93 for best practices on a few tickets. Do we have another ticket that speaks about that?

JennaySDavis commented 1 week ago

@johnbeallgsa Yes, I have created ticket #162 for the developers to review the issues identified in the Lighthouse report.

johnbeallgsa commented 1 week ago

Thank you for showing this in Demo. Moving to Done.