Search functionality on the FISMA report is not functioning

[hatfieldjm4]

When attempting to search on the FISMA system report, the search feature does not work-- it is unreactive when you type in a term. The same is true of the searching on individual fields option in the FISMA system report.

[hatfieldjm4]

This seems to be an issue with the date formatter in the shared.service.ts file (line 188) in the src/app/shared/services/shared folder. It may have errored because Login.gov is the only system-level, active, fisma-reportable system that does not have a Renewal_Date because of it's ongoing FedRAMP authorization.

Troubleshooting steps taken:

• I deleted this formatting in the src/app/views/security/fisma/fisma.component.ts file (by commenting out references to "dateFormatter"), and the serach functionality started working again. I then added it back in to align with how it was originally.
• I tried adding a Renewal_date value for Login.gov in the dev database. This also fixed it.
• I then deleted the Renewal_date value for Login.gov, and it still worked in my local environment. However, it still did not work on dev.ea.gsa.gov.

Next steps:

• [x] Check the next nightly import from the Archer file to see if it put a phantom value in the Renewal_Date field for Login.gov
• [x] Push to production to determine if the FISMA system report is now searchable (I have not pulled the GitHub repo to the dev.ea.gsa.gov site for a while because I've basically been without access to the app servers for a month due to ongoing laptop issues).

[hatfieldjm4]

I simply added an "else return null;" statement to the shared.service.ts file which made the search function properly again. I pushed this to the one-db-schema branch.

[hatfieldjm4]

Looks like that fix did not end up fixing it. It seemed to fix it once, then reverted back to not working again. The same thing is happening on the IT Standards report when the expiration date is enabled.

[hatfieldjm4]

I attempted to use DatePipe with the instructions here: https://stackoverflow.com/questions/40526102/how-do-you-format-a-date-time-in-typescript

While it formatted the date properly, it still broke when searching on the table.

[hatfieldjm4]

I installed the moment npm package ("npm install moment"), and used the moment library to format the date with the instructions here: https://stackoverflow.com/questions/40526102/how-do-you-format-a-date-time-in-typescript

It formatted the date properly and enabled the search to function without error.

[hatfieldjm4]

I realized moment.js will no longer be supported, so I determined a simple js Date object will fix it. I uninstalled moment and pushed to dev & dev1.