search

GSA / api-standards

API Standards for GSA
Other
30 stars 8 forks source link

Initial round of feedback on GSA API Standards #7

Closed Ryandaydev closed 7 years ago

Ryandaydev commented 7 years ago

This pull request contains the initial creation of the GSA API Standards. Because this repository is forked from the 18F API Standards, the original version of this file was the current 18F standards.

Please read guidelines for contributing to understand the process to follow to review, comment, and contribute to these.

Ryandaydev commented 7 years ago

Feedback from Cindy Smith review (other comments directly in pull request view):

Under heading ‘Use a consistent date format’ – Change to: For dates only they shall be displayed as 2013-02-27 and for full times they shall display as 2013-02-27T10:00:00Z.

Response: leaving as is. Content is not changed, just writing style. (This was not changed from original.)

Under heading ‘Server Name Identification’ – last sentence after bulleted items states ‘When implementing SSL support…..’ should this state SNI support?

Response: no change needed

Under heading ‘Public domain’ – in the 1st sentence remove the word ‘and’ after the comma.

Response: no change needed