search

GSA / ckanext-geodatagov

data.gov extension
Other
36 stars 39 forks source link

Overwrite harvest after_show #188

Closed jbrown-xentity closed 1 year ago

jbrown-xentity commented 3 years ago

Related to https://github.com/GSA/datagov-deploy/issues/2854. Tests are still being written. Essentially this overwrites the ckanext-harvest logic to make sure the harvest information is inserted properly. Key component is context.get('validate') is always None, even when this is the first extension run. Therefore we set the default to be False, and let everything be inserted properly. The rest of the PR is just setup to run this function. I can't find any information on this validate piece in context anywhere in ckan core or in our/other extensions; I wonder if this is deprecated? Would like to raise to CKAN community for validation, and an upstream PR (ckanext-harvest) to fix there; at which point we can remove this code.

adborden commented 3 years ago

If you think we've identified a bug in ckanext-harvest, let's fix it there.

btylerburton commented 1 year ago

@jbrown-xentity anything to keep here?

jbrown-xentity commented 1 year ago

We can close this at this point...