GSA / ckanext-geodatagov

data.gov extension
Other
35 stars 39 forks source link

Fix/sitename urls #232

Closed robert-bryson closed 1 year ago

robert-bryson commented 1 year ago

Pull Request

Related to https://github.com/GSA/data.gov/issues/3648

About

PR TASKS

jbrown-xentity commented 1 year ago

As I look at this and think through the implications, I don't like the idea of hardcoding catalog into the sitemap URL. If dev get's indexed (as I would think would happen as google indexes everything eventually) the datasets in dev would point to prod site, and may cause issues. I think the better approach may be to just move this running job to catalog-gather or catalog fetch. Looks like they use the public route (see here), and would provide the correct URL without changing the code. It would also have the benefits of using catalog-admin, as both gather and fetch are connected to SOLR leader and should have latest/up-to-date data available...

robert-bryson commented 1 year ago

Closing to do this instead.