GSA / ckanext-geodatagov

data.gov extension

Other

35 stars 39 forks source link

CKAN_SITE_URL urls in sitemap index + refactoring #236

Closed robert-bryson closed 1 year ago

robert-bryson commented 1 year ago

Pull Request

About

PR TASKS

[x] The actual code changes.
[x] Tests written and passed.
[x] Any changes to docs?
[x] Bumped version number in setup.py (also checked on PyPi).

robert-bryson commented 1 year ago

Looks pretty good, but can we change how the site_url is integrated? Technically we should get it from CKAN config (either CLI or ckan.ini file), not just the CLI environment...

Sure, I have been looking into the config object, but don't see an obvious site_url or something. Do you have something in mind that makes the equivalent to CKAN_SITE_URL available?