search

GSA / ckanext-geodatagov

data.gov extension
Other
35 stars 39 forks source link

changed page size to 10k #257

Closed robert-bryson closed 1 year ago

robert-bryson commented 1 year ago

Bumping sitemap page size count from 1k to 10k to hopefully help Google Search Console along.

nickumia-reisys commented 1 year ago

Does this really need a new release? Can't we just specify it as a command-line argument?

https://github.com/GSA/ckanext-geodatagov/blob/ac17bde49c1b8d1837845fa11d0e8e26271177e1/ckanext/geodatagov/cli.py#L222

btylerburton commented 1 year ago

bump comment by @nickumia-reisys

robert-bryson commented 1 year ago

I think it makes sense to change the default here, given @dlennox24 's experience with sitemaps on other sites. Having a more sane default in the same place is more straight forward. This PR had two purposes: changing the default and helping walk Dan through the moving parts of our codebase.

Yes, @nickumia-reisys you are correct that we can change via the argument as well. I'm not going to fight you on this.