GSA / code-gov-harvester

Stand alone metadata harvester for Code.gov
Creative Commons Zero v1.0 Universal
3 stars 7 forks source link

Add test #15

Closed froi closed 5 years ago

froi commented 5 years ago

So you're you want to submit a Pull Request? Thank you!

Before you submit it please check that a similar PR has not been submitted. You can do a quick search here: Pull request.

If one has not been submitted please fill out the following information so we can understand and work with your PR.

For more information, see our CONTRIBUTING guide.


Summary

This PR is adding tests to this project as stated in issue #2

This PR fixes/implements the following bugs/features

Motivation

Every project should have some tests. It's just the right thing to do.

Tests

Well I am writing them but ....

These are the initial test results. It is just one test at the moment of the creation of the draft PR.

image

Code formatting

image

Closing issues

Closes #2

froi commented 5 years ago

Hey Code.gov.

There is still some work to be done to completely add tests to this project, but I'm noticing that the PR would be to big. I'd prefer to keep this small.

The tests that have been added are for the utils.js and the formatter service. What would you say to leaving this PR here and opening new smaller PRs as tests are being added for other services?

CC: @saracope @AminPIC @bjbhatt

saracope commented 5 years ago

That sounds good @froi. Smaller PR's are my preference. Thanks!

froi commented 5 years ago

Sounds good @saracope. I think you all can review when ready.

Sent with GitHawk