search

GSA / code-gov-harvester

Stand alone metadata harvester for Code.gov
Creative Commons Zero v1.0 Universal
3 stars 7 forks source link

Added date validation #24

Closed seanstar12 closed 5 years ago

seanstar12 commented 5 years ago

So you're you want to submit a Pull Request? Thank you!

Before you submit it please check that a similar PR has not been submitted. You can do a quick search here: Pull request.

If one has not been submitted please fill out the following information so we can understand and work with your PR.

For more information, see our CONTRIBUTING guide.

Summary

Added date validation to formatter. Set invalid dates to fail gracefully. Added test cases for validations. Moved debugging code from 'info' to debug' in logger. Removed extraneous try-catch to pass eslint.

This PR fixes/implements the following bugs/features

Motivation

Invalid dates causing harvester to omit repo.

Tests

See tests/formatter.test.js

Code formatting

Screenshot

Closing issues

jcastle-zz commented 5 years ago

@seanstar12 all merged. Let's see what happens.