GSA / code-gov-web

DEPRECATED 🛑- Federal Source Code policy implementation.
Other
407 stars 110 forks source link

Nav broken #659

Closed saracope closed 6 years ago

saracope commented 6 years ago

Expected Behavior

In the main nav, clicking on an item with a submenu opens that menu.

Current Behavior

Clicking on an item with a submenu jumps the user back to home.

Possible Solution

Update the anchor element.

Steps to Reproduce (for bugs)

  1. Click on a nav link without a submenu, ex. Browse Projects (page loads correctly)
  2. Click on About (Menu flashes and user is taken back to home)

nav-bug

DanielJDufour commented 6 years ago

@saracope , I think we should replace the a tags with divs in the top level that open up submenus

DanielJDufour commented 6 years ago

@saracope , if you got a fix with anchors though, submit a PR :-)