search

GSA / code-gov-web

DEPRECATED 🛑- Federal Source Code policy implementation.
Other
407 stars 110 forks source link

Increase the height of the select tag #681

Closed BalajiJBcs closed 5 years ago

BalajiJBcs commented 5 years ago

Select tag in the code.gov page is small which would give a jarring experience to the user.

Fix: The height of the select tag can be increased to give a better user experience.

Note: It is not good practice to embedded the style inline as I am not sure, the side effect of updating the value universally, So I updated inline. Please have a look into it and update accordingly if need.

Tested on: Chrome Browser, Mac OSx

Here is the snapshot: Before the change :

screenshot 10

After the change 👍

screenshot 7

froi commented 5 years ago

Hi @BalajiJBcs. Thank you so much for submitting this change. It is truly appreciated ❤️

I'll defer to @saracope or @DanielJDufour about this change, but I think the style should not be in-line with the select box. There are other select elements that we would want to have the same styling.

I would prefer this be added to some css file for reusability. Maybe added to the code-gov-style repo?

@saracope any thoughts?

BalajiJBcs commented 5 years ago

@saracope, I will look into it, based on the guidance you provided. Thanks for guiding in this.