GSA / data.gov

Main repository for the data.gov service
https://data.gov
Other
625 stars 99 forks source link

Private datasets on catalog are public #2984

Open FuhuXia opened 3 years ago

FuhuXia commented 3 years ago

Datasets harvested on catalog.data.gov as private are listed to public on /dataset

How to reproduce

Create a harvest source in the Sandbox Organization. Chose Private for Dataset visibility. Let the datasets get harvested.

Expected behavior

Datasets do not show up at /dataset

Actual behavior

Datasets show up at /dataset

Sketch

[Notes or a checklist reflecting our understanding of the selected approach]

mogul commented 3 years ago

Currently this capability is limited to just team members and a few selected partners, and we're not using the private setting ourselves.

FuhuXia commented 2 years ago

We should consider removing this feature all together. Or at least disabling it until we have a good way to reset existing private dataset back to public by re-harvesting or API call, as discussed here.