search

GSA / data.gov

Main repository for the data.gov service
https://data.gov
Other
600 stars 95 forks source link

Log EKS errors during brokerpak testing properly #3695

Open nickumia-reisys opened 2 years ago

nickumia-reisys commented 2 years ago

EKS Brokerpak 2.3.2+

How to reproduce

  1. Provision an eks cluster through the cloud-service-broker.
  2. Run into a non-fatal error

Expected behavior

Provisioning succeeds; but there is a warning or other non-fatal output image

Actual behavior

Provisioning succeeds (in a bad way); but there is no indication of an error image

Sketch

[Notes or a checklist reflecting our understanding of the selected approach] Fix the script that reports progress/success/failure. It tries to report the last action, but it returns null.

nickumia-reisys commented 2 years ago

Attempt to fix with https://github.com/GSA/datagov-brokerpak-eks/pull/77/commits/df64d54ce6e60e48766009afb08bd943ac0b69c8

mogul commented 2 years ago

Not getting in the way much; icebox'ing until we're back to working on brokering EKS instead of directly terraform'ing it up.