Link preview image not displaying correct page title

GSA / data.gov

Main repository for the data.gov service

https://data.gov

Other

607 stars 98 forks source link

Link preview image not displaying correct page title #4723

Closed tdlowden closed 21 hours ago

tdlowden commented 5 months ago

When linking to a catalog page, the link preview image contains Data.gov Home, data.gov. I believe it should show the page title of the page being linked.

How to reproduce

Link to a catalog page in slack, x, facebook, etc
View the link preview

Expected behavior

The link preview should cite the page Title of the page linked

Actual behavior

The link preview displays "Data.gov Home" as the page title

Sketch

Fix the og:title to be the current page title

robert-bryson commented 2 weeks ago

Initial attempt at https://github.com/GSA/ckanext-datagovtheme/pull/212, but the embedded logic isn't quite working correctly so still working on the fix.

robert-bryson commented 2 weeks ago

This is working correctly. Perhaps when updating previously CloudFront had been hitting the cache or something.

Also, when discussing with @tdlowden, we noticed that the 11ty site did not have an image in the link preview. This should be added with this PR.

robert-bryson commented 2 weeks ago

With https://github.com/GSA/catalog.data.gov/pull/1452 this is deployed and working in prod.

The additional fixup (beyond this ticket's scope, but related) for the 11ty site is still in progress.

Closing this ticket.

Bagesary commented 4 days ago

bags to follow up with Robert