mock unit & integration tests to avoid network calls - Githubissues

GSA / data.gov

Main repository for the data.gov service

https://data.gov

Other

547 stars 87 forks source link

mock unit & integration tests to avoid network calls #4767

Closed rshewitt closed 1 month ago

rshewitt commented 1 month ago

User Story

In order to ensure speed and consistency of test runs, datagovteam wants to ensure that all unit & integration tests aren't making live network calls

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

[ ] GIVEN a unit or integration test WHEN it is run without a connection to the internet THEN it should behave exactly as it does with a connection

Background

[Any helpful contextual notes or links to artifacts/evidence, if needed]

Security Considerations (required)

None. This makes our app boundary more explicit.

Sketch

[ ] Bucket specs into the requisite directories: unit, integration, functional
[ ] Exclude functional specs from normal pytest discovery and make test
[ ] Allow make test-ci to run functional specs
[ ] Ensure that tests pass with internet disconnected