search

GSA / datagov-ckan-multi

Other
10 stars 6 forks source link

Add static security analysis to CI/CD pipeline for NG harvester #150

Closed woodt closed 5 years ago

woodt commented 5 years ago

Acceptance criteria:

tkprmr commented 5 years ago

per @woodt he will create tickets based on issues observed per static analysis. overall this ticket is on track for completion by this sprint

woodt commented 5 years ago

Pull request ready to review.

tkprmr commented 5 years ago

@avdata99 to help with pull request review

adborden commented 5 years ago

Can you link to the MR?

On Thu, Oct 17, 2019 at 9:52 AM tkprmr notifications@github.com wrote:

@avdata99 https://github.com/avdata99 to help with pull request review

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GSA/datagov-ckan-multi/issues/150?email_source=notifications&email_token=AAD4OBZNLGLETGCG5JQRB6DQPCJ57A5CNFSM4I2IQFM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQZHDQ#issuecomment-543265678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4OBYFE4ZYKYR2MBBABGDQPCJ57ANCNFSM4I2IQFMQ .

-- Aaron D Borden Lead Engineer | IT Specialist TTS | Data.gov https://www.data.gov

avdata99 commented 5 years ago

This one was merged https://gitlab.com/datopian/ckan-ng-harvest/merge_requests/65

And this is still in progress https://gitlab.com/datopian/ckan-ng-harvest/merge_requests/66

maybe @woodt could add something else

woodt commented 5 years ago

@avdata99: OK, this is ready to go. There are actually two MR for two repos:

(Thanks!)

avdata99 commented 5 years ago

It was merged. Tanks @woodt. If we are done I think you can close it