Enable default flake8 checks on catalog-next

[adborden]

User Story

As a developer, I want all the default flake8 checks running as part of the lint task so that our code is checked with a high quality bar.

Currently, if I remove the --select E9 argument, I get 71,211 errors, most of them in external dependencies which seems wrong.

./ckanext-datagovtheme/ckanext/datagovtheme/tests/test_datagovtheme.py:95:1: W391 blank line at end of file

^
151   E101 indentation contains mixed spaces and tabs
203   E111 indentation is not a multiple of four
28    E114 indentation is not a multiple of four (comment)
4     E115 expected an indented block (comment)
15    E116 unexpected indentation (comment)
59    E117 over-indented
315   E122 continuation line missing indentation or outdented
84    E124 closing bracket does not match visual indentation
15    E125 continuation line with same indent as next logical line
294   E127 continuation line over-indented for visual indent
1816  E128 continuation line under-indented for visual indent
17    E129 visually indented line with same indent as next logical line
17    E131 continuation line unaligned for hanging indent
141   E201 whitespace after '('
85    E202 whitespace before ')'
650   E203 whitespace before ':'
4132  E211 whitespace before '('
69    E221 multiple spaces before operator
35    E222 multiple spaces after operator
639   E225 missing whitespace around operator
2     E228 missing whitespace around modulo operator
12992 E231 missing whitespace after ':'
1128  E251 unexpected spaces around keyword / parameter equals
16979 E261 at least two spaces before inline comment
52    E262 inline comment should start with '# '
536   E265 block comment should start with '# '
155   E266 too many leading '#' for block comment
11    E271 multiple spaces after keyword
6     E272 multiple spaces before keyword
316   E301 expected 1 blank line, found 0
1513  E302 expected 2 blank lines, found 1
244   E303 too many blank lines (2)
1     E304 blank lines found after function decorator
114   E305 expected 2 blank lines after class or function definition, found 1
39    E306 expected 1 blank line before a nested definition, found 0
27    E401 multiple imports on one line
104   E402 module level import not at top of file
7016  E501 line too long (81 > 79 characters)
84    E502 the backslash is redundant between brackets
195   E701 multiple statements on one line (colon)
5     E702 multiple statements on one line (semicolon)
32    E703 statement ends with a semicolon
85    E711 comparison to None should be 'if cond is not None:'
72    E712 comparison to True should be 'if cond is True:' or 'if cond:'
39    E713 test for membership should be 'not in'
15    E721 do not compare types, use 'isinstance()'
61    E722 do not use bare 'except'
9     E731 do not assign a lambda expression, use a def
52    E741 ambiguous variable name 'l'
523   F401 're' imported but unused
4     F402 import 'tag' from line 606 shadowed by loop variable
158   F403 'from sqlalchemy import *' used; unable to detect undefined names
1204  F405 'MetaData' may be undefined, or defined from star imports: migrate, sqlalchemy
16    F601 dictionary key 'ckan.template_head_end' repeated with different values
6     F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
23    F811 redefinition of unused 'urllib' from line 4
15    F812 list comprehension redefines 'rev' from line 284
21    F821 undefined name 'rating_opts'
1     F822 undefined name 'PackageTag' in __all__
1     F823 local variable 'xrange' defined as a builtin referenced before assignment
366   F841 local variable 'GET' is assigned to but never used
2     F901 'raise NotImplemented' should be 'raise NotImplementedError'
16591 W191 indentation contains tabs
216   W291 trailing whitespace
19    W292 no newline at end of file
778   W293 blank line contains whitespace
94    W391 blank line at end of file
158   W601 .has_key() is deprecated, use 'in'
38    W602 deprecated form of raising exception
112   W603 '<>' is deprecated, use '!='
2     W604 backticks are deprecated, use 'repr()'
210   W605 invalid escape sequence '\.'
71211
make: *** [lint-all] Error 1

Acceptance Criteria

• [ ] GIVEN I remove the --select E9 from the lint task WHEN I run make lint-all THEN I see flake8 runs against the code in catalog.data.gov with the default checks

Details / tasks