search

GSA / datagov-ckan-multi

Other
10 stars 6 forks source link

Export Drafts does not include draft datasets #527

Closed adborden closed 3 years ago

adborden commented 3 years ago

From https://github.com/GSA/datagov-ckan-multi/issues/422, we realized that the old form was using publishing_status for draft status, but the new form is using CKAN's draft state (state: draft). This breaks the export draft datasets funcitonality.

How to reproduce

  1. Browse to the new dataset form https://inventory.sandbox.datagov.us/dataset/new-metadata
  2. Fill out the required info.
  3. Click Save and Continue
  4. Click Return to Dashboard
  5. Click Export Drafts
  6. Extract the zip file
  7. Inspect the data.json

Expected behavior

data.json contains the new draft dataset.

Actual behavior

data.json contains no datasets.

avdata99 commented 3 years ago

I will add a test case to export draft.json file and check if the save and draft datasets from the inventory are included

avdata99 commented 3 years ago

Tests were added in DataJOSN#92.

avdata99 commented 3 years ago

Tests are green @anuveyatsu. If the published_status is working we can move this to QA https://github.com/GSA/ckanext-datajson/blob/master/ckanext/datajson/test-inventory/test_export.py#L47