a11y - Use landmarks for DG Banner and Glossary - Githubissues

GSA / digitalgov-pra

A resource to help federal employees comply with the Paperwork Reduction Act (PRA)

https://pra.digital.gov/

Other

12 stars 18 forks source link

a11y - Use landmarks for DG Banner and Glossary #348

Closed mejiaj closed 1 year ago

mejiaj commented 1 year ago

This PR closes the card: PRA: Ensure all page content is contained by landmarks.

⚠️ I'm using axe-core 4.6.3 and didn't get the landmark errors. But I've added some as best practice.

Affected components

Digitalgov Banner

Glossary

Additional changes

Added ESBuild to bundle javascript
Added NPM script to build JS build:js
Removed unused dependencies for CSS/JS
Used section with aria label for digitalgov banner
Ran prettier formatting on JSON files

How to test

There should be zero a11y errors (specifically landmarks)
There should be zero visual regressions
Glossary works as intended

nick-mon1 commented 1 year ago

@mejiaj Updates look good.

axe-core 4.6.3 shows no issues and the new esbuild runs fine. Thanks for the improvements.