search

GSA / digitalgov.gov

Digital.gov: Better websites. Better government.
https://digital.gov
Other
214 stars 298 forks source link

Default to full sized images #7762

Closed lcummings12 closed 3 days ago

lcummings12 commented 2 weeks ago

Summary

Updated the img shortcode to change the default size in the src attribute from 800px to 1200px, ensuring images are displayed at their correct sizes.

Also refactored markup to serve images responsively, previous code (srcset and sizes) was not setup for responsive images.

Preview

Link to Preview

Solution

Changed the default size in the src attribute from 800px to 1200px. This ensures that the larger image size is used by default, addressing the issue of images appearing smaller than intended.

How To Test

  1. Open the preview link to verify that images are displayed at their intended sizes.
  2. Compare with the original design using the Wayback Machine to ensure consistency.
  3. Resize the browser window to test the responsive behavior of the images.
page preview production
Making GSA’s public art collection more accessible link link
Evaluating your agency’s accessibility just got a whole lot easier with GSA’s OpenACR Editor link link
Determining the true value of a website: A GSA case study link link
Delivering seamless customer journeys link link
Customer experience and human-centered design link link

Code with bug

Screen Shot 2024-07-02 at 12 21 02 PM

Fixed code

Screen Shot 2024-07-02 at 12 21 47 PM

Code before bug was introduced

Screen Shot 2024-07-02 at 12 22 08 PM

Dev Checklist

github-actions[bot] commented 2 weeks ago

:mag: Preview in Federalist

lcummings12 commented 1 week ago

Fixed to address all the problematic pages hi-lighted by @ToniBonittoGSA below.

Updated page 1 Production page 1

Updated page 2 Production page 2

Updated page 3 Production page 3

Updated page 4 Production page 4

Updated page 5 Production page 5