search

GSA / digitalgov.gov

Digital.gov: Better websites. Better government.
https://digital.gov
Other
218 stars 299 forks source link

Refactor markup for page templates #7795

Closed ch-tyson closed 4 weeks ago

ch-tyson commented 1 month ago

Summary

Refactors markup for single.html template to be more consistent. Removes unused classes and duplicate markup.

[!NOTE] This PR should wait before merging #7803 & #7805

single.html

Preview

[Link to Preview]()

Solution

Refactored markup to match a consistent hierarchy for all single.html pages.

main
  article
    header
    div.in-page-nav-container
    aside.usa-in-page-nav
    div.content.usa-prose

Dev Checklist

github-actions[bot] commented 1 month ago

:mag: Preview in Federalist

RileySeaburg commented 1 month ago

@nick-mon1 @lcummings12 now that the other 2 prs are merged, we have some conflicts to solve here.

nick-mon1 commented 1 month ago

@RileySeaburg Addressed merge conflicts

RileySeaburg commented 1 month ago

@RileySeaburg Addressed merge conflicts @nick-mon1 Can you approve this as well?