search

GSA / digitalgov.gov

Digital.gov: Better websites. Better government.
https://digital.gov
Other
218 stars 299 forks source link

Youtube video embed update #7877

Closed clmedders closed 3 weeks ago

clmedders commented 3 weeks ago

Summary

TL;DR -> removed autoplay from youtube embed url and update styles to match Digital theme

Removed the ?autoplay=1 from the youtube embedded urls to help address the videos playing once a user loads the page. Also updated the background color or the video to match one of Digital color themes.

Preview

Link to Preview

Solution

Added the BEM naming of dg-youtube and removed the uswds class of stage, also moved the styles from stage class to the new dg-youtube class for better control of styles in the future.

Also removed the autoplay within the url to address an issue with the video playing once a user loaded the page

How To Test

  1. visit Link to Preview and check that the video is not autoplaying, also verify that the video plays with now error
  2. inspect element and verify that the new dg-youtube class is applied and the new background color is #ecf1f7
github-actions[bot] commented 3 weeks ago

:mag: Preview in Federalist