Open nick-mon1 opened 2 weeks ago
:mag: Preview in Federalist
@nick-mon1 did you test upload with this?
@RileySeaburg This is probably not be related to these code changes for displaying and generating the same image types. Still need to address async issues with gulp file upload scripts.
Thought
@RileySeaburg This is probably not be related to these code changes for displaying and generating the same image types. Still need to address async issues with gulp file upload scripts.
@nick-mon1 I would agree completely if the image upload didn't already work. But I do agree this is an async issue.
Summary
Updates code to only generate and serve
mobile (800)
anddesktop (1200)
responsive sizes.Preview
Solution
Simplified responsive variants from 4 to 2 sizes. Serving one size for mobile and desktop will not impact performance and quality.
What you should see in network panel
Updates the
file-process.js
to generate the above two sizes. Updatesimg.html
partial/short code to display above two sizes.Other variant sizes will be served if the
800
or1200
is not present.How To Test
800
or1200
size, other image size is served