search

GSA / innovation.gov

Deprecated - This project repo is no longer being maintained.
https://innovation.gov
14 stars 14 forks source link

Innovation ecosystem table #87

Closed contolini closed 5 years ago

contolini commented 5 years ago

@imuchnik pull this down when you have a second and let me know your thoughts. This branch is based off yours but I swapped out the bootstrap table with a more powerful table library. I kept all your HTML for the page.

Column sorting, pagination and search functionality have been implemented. Filtering by category still needs to be worked on. It's set up to pull the data directly from the spreadsheet which is why a lot of the cells are empty (the spreadsheet is still missing some data).

And there's still lots of visual clean up (spacing, typography) that needs to be done.

Testing

Screenshots

Filtering by keyword:

screen shot 2018-10-09 at 12 58 54 pm

Column sorting:

screen shot 2018-10-09 at 1 00 07 pm
imuchnik commented 5 years ago

LGTM. Small issues with navigation, see #88. and I just notice a minor css issue.

imuchnik commented 5 years ago

Wait @jeremyzilar, why was this closed before it was merged?

atrain440 commented 5 years ago

@imuchnik: I can explain what's happening--will email you to explain next steps.