search

GSA / jenkins-deploy

deploy Jenkins to AWS with Terraform and Ansible
Other
20 stars 14 forks source link

use HTTPS only #13

Closed afeld closed 7 years ago

afeld commented 7 years ago

Closes #12.

This pull request adds an nginx proxy in front of Jenkins to serve requests - this seemed more trustworthy and configurable than relying on Jenkins to do HTTPS termination itself. While the example security group setup leaves port 80 open, this is simply to redirect to 443. My test deployment, using a self-signed cert (hence why it says "Not Secure"):

dashboard__jenkins__and_jdauphant_ansible-role-ssl-certs__generate_and_or_deploy_ssl_certificate

Note that all the files under test/roles/ are vendored third-party dependencies.

afeld commented 7 years ago

@yfuksenko This pull request has changed a bit - mind taking another look? I suggest we take care of any additional hardening as follow-up(s).

afeld commented 7 years ago

Got verbal re-approval from @yfuksenko, so merging!