GSA / jenkins-deploy

deploy Jenkins to AWS with Terraform and Ansible
Other
20 stars 14 forks source link

remove vendored roles #26

Closed afeld closed 7 years ago

afeld commented 7 years ago

Since the versions aren't being locked for users when they include this role, we shouldn't assume a particular version for the tests. Also, it cuts down the number of files / noise in the repository.

afeld commented 7 years ago

The tests/ directory probably isn't the best name for what it represents: the playbook/roles/etc. in there are what I've been using to try out the reusable top-level role (for setting up GSA-specific Jenkins) in a standalone way. In other words, it's the integration test.

tests/roles/ is where the third-party dependency roles get downloaded. The change is that I'm removing that folder from version control.

Once CircleCI gets enabled for the @gsa GitHub organization, I intend to have tests/test.yml actually be run within a container, to test the role with continuous integration. /cc #20

Does that make sense?

kishorebabu12 commented 7 years ago

This makes sense.