search

GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

Bug: There should be a placeholder text that says "No batched job messages found..." #1224

Open heyitsmebev opened 8 months ago

heyitsmebev commented 8 months ago

Who discovered this?

beverly

What happened?

In staging, it's missing a placeholder text when there's no notification or job. Image

There should be a placeholder text that says "No batched job messages found  (messages are kept for {{ service_data_retention_days }} days), when recent batch table is empty.

it works in local though

Image

            <tr class="table-row">
              <td class="table-empty-message" colspan="10">No batched job messages found &thinsp;(messages are kept for {{ service_data_retention_days }} days).</td>
            </tr>

Environment

staging

What pages did this appear on?

dashboard

Detail the steps for someone to reproduce

When recent batch table is empty. No notifications or jobs have been sent.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

heyitsmebev commented 8 months ago

this ticket completed with this PR: https://github.com/GSA/notifications-admin/pull/1244