GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

QA for 4/17/2024 production deploy #1429

Closed ccostino closed 4 months ago

ccostino commented 4 months ago

Log In

Create a template and send

Send a message from copied template

Send a message from existing template

Download the csv delivery report

Invite a team member

Delete a team member

Sign Out

Specific Issues to review

We have a handful of issues that are ready to be reviewed or could use verification whether or not they're fixed or need more follow up:

TODO

We're waiting on a couple of things to still be completed and merged to staging:

ccostino commented 4 months ago

I think we've already captured this, but noting here again that when you go to create a new template and copy from an existing template, you don't see a list of any of the existing templates and can only search by name, which means you have to remember which templates exist.

heyitsmebev commented 4 months ago

@ccostino Everything on the QA list worked for me except the items listed below.

Send a message from copied template

heyitsmebev commented 4 months ago

If I'm signed out and I somehow land on "You need to sign in again" page...There's no sign in inputs.

image
ccostino commented 4 months ago

Awesome, thanks for capturing these @heyitsmebev! We'll follow up to see if we're dealing with known issues or need to create new ones, and if any of these are actual show-stoppers.

As for the sign-in again form there, that's a known issue that @em-herrick has already flagged that still needs to be taken care of - it's on our list of TODOs above that @jonathanbobel is working on! 🙂

ccostino commented 4 months ago

Something else that we might need to account for: when I invited myself to another organization (the TTS organization), I got the email as expected and then clicked on the link.

From there, it prompted me to sign in with Login.gov, which is what I believe we want now, except in this case I was already signed in to the site...

I still signed back in, and was then taken to the set up my profile page, where it said a security code would be texted to me (that never happened):

Screenshot 2024-04-16 at 6 11 33 PM

I filled things in anyway, and then took me to the usage page for the org:

Screenshot 2024-04-16 at 6 12 59 PM

And finally I clicked on Team Members, where I see me listed as an invited user with the option to still cancel, even though I had accepted:

Screenshot 2024-04-16 at 6 12 18 PM

It's entirely possible I broke the flow here by being a platform admin and signed in, inviting myself to an org with the exact same email and going from there.

EXTRA NOTE

This is with an organization invite flow, which is different than a service invite flow!

em-herrick commented 4 months ago

A small fix here is that on the Set up your profile page under the Mobile number the copy here is out-of date, we no longer send security codes.

We should replace with: We need your number so you can send yourself test texts.

Screenshot 2024-04-17 at 9 32 14 AM
ccostino commented 4 months ago

Ah yes, this is what I was seeing yesterday too in the set up your profile form, thanks @em-herrick!

Update: now it's own issue

A-Shumway42 commented 4 months ago

@ccostino The allowance updates to 250,000 when switching the service to live. The values aren't updating now? I sent a few text to verify.

Screen Shot 2024-04-17 at 8 01 41 AM

I tested locally in dev and the values update. Possibly a staging issue?

ccostino commented 4 months ago

🤔 I'm not sure, @A-Shumway42, so once the service was switched to live the updates to the counts stopped working?

Is this an existing service that was creating a while back, or a new one you just set up for testing?

jskinne3 commented 4 months ago

While investigating #1427 I encountered two broken links: Screenshot 2024-04-17 at 9 35 20 AM

Both lead to a "Page not found" at these two URLs:

The double slash (//) in the path looks like something is missing.

As a result of this I can't say for sure if user story 1427 is complete or not

ccostino commented 4 months ago

Added an issue for the "you need to sign back in" template - the Login.gov button is missing.

A-Shumway42 commented 4 months ago

@ccostino this was a new service in staging. I logged back into staging and it appears it is working now. I'm not sure what the delay was on the count.

Screen Shot 2024-04-17 at 10 56 52 AM
ccostino commented 4 months ago

Oh strange, @A-Shumway42! Two things come to mind that we could look into further to see:

jskinne3 commented 4 months ago

When investigating issue #1270 I found that there is some text in the google doc draft of email language which does not appear in the email:

Notify.gov uses Login.gov to allow you to sign in safely. Login.gov is a secure sign in service to help you access participating government agencies’ digital touchpoints.

Unsure if this was actually supposed to be included, or if it was old and discarded text

A-Shumway42 commented 4 months ago

@ccostino Hard to verify now. I'm not receiving messages to my phone and I've sent a few more in staging. The dashboard still has a count of 2 in the count at the bottom and the top. I also can't access logs in staging because my cf cli can't login...oof.

ccostino commented 4 months ago

@A-Shumway42 okay - I noticed some delays with messages going out yesterday myself - you might be able to see some activity (or not!) in AWS in the staging account, but I think we're okay for now and we can follow up on this more if need be.

@heyitsmebev, thanks for all of your reports there! It looks like the discrepancies with the templates are more so with the QA checklist and not the site itself, so we'll have to update that issue template. 🙂 As for the sign in again page, that's tracked here and nearly wrapped up!

@jskinne3, thanks for reporting these! Sure enough those are bugs caused by the current information architecture of all things. Those two links are tied to a service and only work if you've clicked into a service first - they are settings page for a service, not global/universal for just your user account. So thank you for flagging, @em-herrick and I confirmed this just a bit ago! As for the template, thanks for flagging that too; it looks like it didn't get fully updated for some reason, and highlights that the template updating process is still a bit wonky.

@em-herrick and I will write up separate issues to track the things that we do need to follow up on from all of this. Thank you all!

ccostino commented 4 months ago

Our production release has gone out and new issues have been created. Thanks, everyone!