GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

fix set and get in redis_client #1600

Closed terrazoon closed 3 weeks ago

terrazoon commented 4 weeks ago

Description

Originally in Notify UK, redis_client.set() and redis_client.get() were wrapped in try/except, which make it very difficult to debug when there was an actual problem with redis, as we experienced a few months back.

At the time we added new methods raw_set() and raw_get() to get exceptions raised in key areas, but now let's clean things up and have exceptions always raised.

Security Considerations

N/A

ccostino commented 3 weeks ago

Never mind, I see what happened with poetry.lock, I'm getting that too - I have it covered in #1604.

ccostino commented 3 weeks ago

@terrazoon with the dependency updates taken care of now, whenever you have a moment to update this PR against main again please do so and then we can merge. 🙂 Thanks!