GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
10 stars 2 forks source link

Redis upgrade step 1 #1650

Closed jskinne3 closed 1 week ago

jskinne3 commented 1 week ago

Similar to https://github.com/GSA/notifications-api/pull/1104, create a new Redis resource in all environments. This is the first step of the upgrade. Next steps are to unbind the old Redis instance, bind the new, and then delete the old.

Redis v6.2 → v7.2

🔴 Terraform plan is failing because this PR depends upon #1649 🟢 checks are green and this is ready to merge

github-actions[bot] commented 1 week ago

Terraform Format and Style: success Terraform Initialization: failure Terraform Validation: skipped Terraform Plan: skipped

Show Plan ``` ```

Pusher: @jskinne3, Action: pull_request

github-actions[bot] commented 1 week ago

Terraform Format and Style: success Terraform Initialization: failure Terraform Validation: skipped Terraform Plan: skipped

Show Plan ``` ```

Pusher: @jskinne3, Action: pull_request

github-actions[bot] commented 1 week ago

Terraform Format and Style: success Terraform Initialization: success Terraform Validation: success Terraform Plan: success

Show Plan ``` module.redis.data.cloudfoundry_space.space: Reading... module.redis-v70.data.cloudfoundry_service.redis: Reading... module.api_network_route.data.cloudfoundry_space.space: Reading... module.redis.data.cloudfoundry_service.redis: Reading... module.redis-v70.data.cloudfoundry_space.space: Reading... module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading... module.logo_upload_bucket.data.cloudfoundry_space.space: Reading... module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054] module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054] module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b] module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c] module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c] module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c] module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=a6e88a48-bae7-4cf4-84d5-3a86463e8814] module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=d67c8c05-f22b-4fca-ba0b-312af08a61eb] module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c] module.api_network_route.data.cloudfoundry_app.source_app: Reading... module.api_network_route.data.cloudfoundry_app.destination_app: Reading... module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=5d983d08-5079-4159-8721-67edf948d345] module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=89c9b6a9-f030-4752-b30f-6b3193a25148] module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=45c461a7-cc6c-c60d-cea7-1f5480589b64] Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: + create Terraform will perform the following actions: # module.redis-v70.cloudfoundry_service_instance.redis will be created + resource "cloudfoundry_service_instance" "redis" { + id = (known after apply) + json_params = jsonencode( { + engineVersion = "7.0" } ) + name = "notify-admin-redis-v70-staging" + replace_on_params_change = false + replace_on_service_plan_change = false + service_plan = "39e035d8-f847-4bf5-a2ee-521c3118cc42" + space = "9745decb-4988-4bab-88a4-e3f07b36241c" + tags = [] } Plan: 1 to add, 0 to change, 0 to destroy. Warning: Argument is deprecated with module.logo_upload_bucket.cloudfoundry_service_instance.bucket, on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket": 14: recursive_delete = var.recursive_delete Since CF API v3, recursive delete is always done on the cloudcontroller side. This will be removed in future releases (and one more similar warning elsewhere) ───────────────────────────────────────────────────────────────────────────── Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now. ```

Pusher: @jskinne3, Action: pull_request