GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

Bug: Missing phone numbers in CSV download #1745

Open em-herrick opened 1 month ago

em-herrick commented 1 month ago

Who discovered this?

Frank from WA

What happened?

A bug happened! CSV not displaying all phone number data.

Image

Environment

production

What pages did this appear on?

7-day report download

Detail the steps for someone to reproduce

unclear

What browsers are you seeing the problem on?

No response

Relevant log output

No response

ccostino commented 1 month ago

We think we have a couple of solid leads to investigate here that might be at play:

At the moment, it sounds like the best path forward is exploring why we aren't able to reach S3 properly as the fallback here, in addition to seeing or confirming why the expiring dict is failing like it is, which we surmise is likely because of app instance reboots clearing out memory. If we can iron out the S3 connection, we can create a fallback mechanism to safely rebuild the expiring dict cache by reaching out to S3 and pulling the data it needs upon app initialization (so at the time the app starts back up) - this'll have to be safe and account for the app running in cloud.gov vs. locally.

Additionally, we should engage with our ISSO/ISSM and start having another conversation about longer term ramifications and solutions that involve the handling of PII to try and make this all easier for ourselves. This will take some time though, and the potential path forward above with fixing the S3 and expiring dict handling seems like a very good lead to us.

ccostino commented 1 month ago

ExpiredDict updates are now in staging, ready for testing before prod rollout.

em-herrick commented 1 month ago

@ccostino and @terrazoon —If we have a fix for this ready to go can we prioritize getting it deployed soon? WA is still reporting missing phone numbers in their report. I fear the longer this goes on the more historic data we'll need to be retrieving adhoc for partners (like we need to for CA and MoCo).

ccostino commented 1 month ago

Yes, this is slated to go out with a variety of other things as soon as we're done with QA and fix the remaining issues we've found. There's nothing major, so the plan is either later today (7/24/24) or tomorrow!