GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

User Story: BackstopJS Spike #1876

Closed alexjanousekGSA closed 1 week ago

alexjanousekGSA commented 3 weeks ago

As a developer, backstopJS should be investigated to see if it holds benefits over playwright and if so, should then be implemented.

I want backstopJS to help improve our testing suite.

So that the code quality of the app goes up and UI bugs are reduced.

Verify differences between backstop JS and playwright.

alexjanousekGSA commented 3 weeks ago

Playwright:

BackstopJS

alexjanousekGSA commented 3 weeks ago

This is what backstop looks like passing on the homepage:

image
alexjanousekGSA commented 3 weeks ago

When adding one word of text, the report fails:

image
alexjanousekGSA commented 3 weeks ago
image
alexjanousekGSA commented 3 weeks ago

Document with findings - https://docs.google.com/document/d/1K2FxD4iCXjOCSFE9kott6kchtBE7ziMkmYr1LifPKw4/edit

alexjanousekGSA commented 2 weeks ago

Continuing on with writing an ADR for this now!

alexjanousekGSA commented 2 weeks ago

Link to ADR Issue

alexjanousekGSA commented 2 weeks ago

PR is out as well for ADR - https://github.com/GSA/notifications-api/pull/1297