GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

User Story: Provide endpoint to search All Jobs #1897

Open jonathanbobel opened 2 months ago

jonathanbobel commented 2 months ago

As a [type of user],

Front-end developer

I want [an action or feature],

an endpoint for searching/filtering All Jobs on the Activity page

So that [benefit or value].

a front-end developer can finish building out the search functionality for our users

Detailed condition or criteria that must be met for the user story to be considered complete.

List of specific tasks or sub-tasks that need to be done to implement the user story.

List any dependencies that need to be resolved before starting or completing this user story.

No response

Any additional information or context that might be useful for the team.

Reference this PR to take a look at how the current javascript is working to filter the table, albeit just one page in the DOM (if it's paginated)

terrazoon commented 2 months ago

@jonathanbobel

em-herrick commented 2 months ago

@xlorepdarkhelm Wondering what the level of effort is here to get an end-point for search.

We'd like to prioritize this for next sprint so we can close out the lingering epic related to this.

xlorepdarkhelm commented 2 months ago

Example extension that can provide searching/filtering: https://exleym.github.io/Flask-Filter/

In theory, this is possible. Filtering RESTful APIs is a.... complex concept, especially when trying to build filters dynamically. The extension I linked does filtering, and sorting even. (Searching is simply filtering out the stuff that isn't what you are looking for).

I am not prescribing this extension as the solution, as thre are some issues with adding more extensions to our dependency chains. However it is probably much quicker to be set up than manually making it work. But we rise potntial for security problems with a new extension. so...

I believe this is something that might need a real spike done to track it down completely. I hesitate to guess at what the level of effort would be without further looking into the details. I will continue to look into it here and see if I can get that estimate.

xlorepdarkhelm commented 2 months ago

I would say that it should be OK to add the extension in, and see where it leads, with that, I don't see this being too extremely complex to write. It could easily be done wihin a sprint, I would imagine, and then there would be searching available on this endpoint.

em-herrick commented 1 month ago

Cool! Thanks for the update here—i'd love to make progress on it this sprint!