GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

Variable condition restrictions #1956

Open em-herrick opened 1 month ago

em-herrick commented 1 month ago

Issue

Oregon is hoping to send messages using variable information in one-off sends: ((insert local office phone number)). They would like to use variable data to indicate a needed local office phone number, and have each sender fill in the right phone number as part of the one-off sending process.

We found, that including the words "phone", "number", and "contact" as variable data confuses Notify and causes messages to be sent with this template to fail. See video:

https://github.com/user-attachments/assets/d7a7ad11-71f6-4b49-a7b8-e61f5496008e

To reproduce:

  1. Create a new template
  2. Use this template text:

Hello, this is ((insert your name)) from ODHS. I will be giving you a call in the next five minutes from 1-503-945-5722 to talk about your recent request for benefits. If you would like to verify this message, please contact us at ((insert local office phone number)).

  1. Observe that the last variable is not highlighed yellow
  2. Use template
  3. Send to your self / one phone number
  4. Insert your first name
  5. insert 1-888-999-0000 as second variable
  6. observe the fail

Desired State:

em-herrick commented 1 month ago

Fix— exact match for "phone number" is not allowed. "insert phone number" is okay.

"contact" is still an unknown issue

terrazoon commented 1 month ago

https://github.com/GSA/notifications-api/pull/1336