GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

Make e2e tests work fully with staging API #1996

Closed terrazoon closed 1 month ago

terrazoon commented 1 month ago

Description

  1. Get the end-to-end tests to work 100% with the staging API. The issue was that the S3 configuration for staging was not readable down at the level where we launch the admin server that performs the tests. The solution for now is to copy the S3 configuration into a secret for the staging tier (notes on how to do this in the README).

  2. Once the tests work, finish checking every page that loads for accessibility violations

  3. Fix one accessibility violation (use of the h4 heading when it's not hierarchied as a subheading. Replace with h2)

  4. Write a ticket for another accessibility violation (use of scope="row" outside of a table header)

  5. Raise the level of accessibility violation that causes a test failure back up to 'serious' for now. I guess until we have a full e2e test suite, it's pointless to set the level to 'moderate' because there are still moderate violations lurking in the html.

Security Considerations

N/A