GSA / notifications-admin

The UI of Notify.gov
https://notify.gov
Other
11 stars 2 forks source link

Moderate Accessibility Violation scope="row" outside table header #2001

Open terrazoon opened 1 month ago

terrazoon commented 1 month ago

tests/end_to_end/test_send_message_from_existing_template.py::test_send_message_from_existing_template[firefox] - AssertionError: Accessibility violation: {'id': 'scope-attr-valid', 'impact': 'moderate', 'tags': ['cat.tables', 'best-practice'], 'description': 'Ensures the scope attribute is used correctly on tables', 'help': 'scope attribute should be used correctly', 'helpUrl': 'https://dequeuniversity.com/rules/axe/4.4/scope-attr-valid?application=axeAPI', 'nodes': [{'any': [], 'all': [{'id': 'html5-scope', 'data': None, 'relatedNodes': [], 'impact': 'moderate', 'message': 'In HTML 5, scope attributes may only be used on table header elements ()'}], 'none': [], 'impact': 'moderate', 'html': '\n \n aecfcbc2\n \n ', 'target': ['.jobid'], 'failureSummary': 'Fix all of the following:\n In HTML 5, scope attributes may only be used on table header elements ()'}]} assert 'moderate' in ['minor']

terrazoon commented 1 month ago

To see the error, edit the /tests/end_to_end/conftest.py file to not skip 'moderate' violations and then run the e2e tests.