Update to USWDS 3.8.0 - Githubissues

jfredrickson commented 6 months ago

The USWDS 3.8.0 update contains a breaking change that will affect our side navigation. In order to be able to continue updating USWDS, we need to make couple of tweaks on our end. Specifically:

We need to either: duplicate the side navs at both the top and bottom of the page (their recommended approach), or simply revert to the old rendering (they state that this could cause usability issues)
We need to review the slightly different appearance of the side nav (it seems to be a bit more narrow) and ensure it is consistent with our design needs, adjusting it if not

For more info: https://github.com/uswds/uswds/releases/tag/v3.8.0

weiwang-gsa commented 6 months ago

@klohman this is ready for design review: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/demo/gsa/oasis-plus/oasis-plus/buyers-guide/research-contract-features/

klohman commented 6 months ago

@weiwang-gsa 👍 ready for PSHC

weiwang-gsa commented 6 months ago

@klohman should I move it to ready for PSHC or directly to done? this actually have no UI change, we just make sure after USWDS upgrade, the side nav on mobile view still stay at the bottom.

klohman commented 6 months ago

@weiwang-gsa Let's move to done since there is nothing to review.

@PowderD @ekidenda

GSA / oasis-plus

Update to USWDS 3.8.0 #393