search

GSA / oasis-plus

1 stars 0 forks source link

UPDATE: Domains and labor categories #446

Open vickimcfadden opened 6 months ago

vickimcfadden commented 6 months ago

Update existing page (#56) with new content.

jfredrickson commented 6 months ago

Review: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/preview/gsa/oasis-plus/jf/domains-labor-categories/oasis-plus/about/domains-naicscodes-scope-labor-categories/

vickimcfadden commented 6 months ago

I'll do QA for this one.

vickimcfadden commented 6 months ago

@klohman is What’s in scope / out of scope supposed to be H3?

klohman commented 6 months ago

@vickimcfadden Yes, "What’s in scope / out of scope" should be a H3 (missed that in the content doc)

vickimcfadden commented 6 months ago

@jfredrickson ☝️ could you make this change, and then I think we can consider this done from a design/QA perspective!

jfredrickson commented 6 months ago

@vickimcfadden okay, updated! https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/preview/gsa/oasis-plus/jf/domains-labor-categories/oasis-plus/about/domains-naicscodes-scope-labor-categories/

vickimcfadden commented 6 months ago

@PowderD @ekidenda ready for your review https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/preview/gsa/oasis-plus/jf/domains-labor-categories/oasis-plus/about/domains-naicscodes-scope-labor-categories/

PowderD commented 6 months ago

@vickimcfadden This looks good. Especially once all the NAICS pages are changed with the updated tables! TY

vickimcfadden commented 6 months ago

Thank you, moving to done!