Open vickimcfadden opened 2 months ago
@klohman let me know if I can start adding links back to TOC section.
@klohman this is ready for SD review at feature branch: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/preview/gsa/oasis-plus/wwang/toc-links/oasis-plus/buyers-guide/printable/
Looks good - @weiwang-gsa
@ekidenda or @PowderD this is ready for QA review: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/demo/gsa/oasis-plus/oasis-plus/buyers-guide/printable/
@vickimcfadden and @weiwang-gsa I've reviewed and tested the page content links - it all looks good to me. Thanks. Moving to done.
Wei: I originally added link to the printable h2 section, as this printable version is pulling content from separate pages into one page, it cause accessibility issues for the link in TOC section and in separate pages, AMP (accessibility tool) complains that same text are linked to different URLs, e.g. "NAICS codes by domain" in table of content link to printable version heading level 2, but in Award the task order section, same text "NAICS codes by domain" is link to the page NAICS codes by domain. The possible solution to address this AMP issue are: 1. change the TOC section text 2.Remove the link or TOC section completely 3.Ignore the AMP accessibility complaints. After discussion with Kristen and Rosamund, as they feel TOC section can give a quick glance of content, we decide to remove the link and only keep the TOC text for now, we will see if there is any user concerns come out of usability testings.
Rosamund: Wei summed it up well. We're going to see if people have issues without a linked TOC. If they do, this seems like an instance where we could overlook the AMP bug; it seems contextual enough that a person with a screenreader (if they're reading the page in a linear order) would hear "Table of Contents" before the TOCs are spoken to them, and know it's not the same link as something else that's within the text. Open to other thoughts but that's where we landed for now.
Kristen: Ditto to Rosamund on the background. We are seeing from usability testing that users do expect these to be links. We can reconsider our options post testing.