GSA / oasis-plus

1 stars 0 forks source link

Remove June 12 event & add August events that already have registration links. #531

Open ekidenda opened 4 months ago

weiwang-gsa commented 4 months ago

@ekidenda I refactored the event code( removed unnecessary code), the changes are, list below

this is ready for your QA: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/demo/gsa/oasis-plus/oasis-plus/events-training/

ekidenda commented 4 months ago

@weiwang-gsa it looks good except the registration link for the August training dates show the full URL inconsistent with the rest of the page. I refreshed the page and it still looks the same fyi.

weiwang-gsa commented 4 months ago

@ekidenda the reason the link still broken is because the code is not been merged in, manually close the PR without approving the PR first, it actually cancel the PR request. As reviewer, if you add your review and approve the PR first, then followed with merge the PR, it will merge the code in and auto close the PR. btw, I just reopened the PR and Mark approve it and it get merged in now, it is ready for your review: https://federalist-76c8d2ee-2655-47f7-8fa4-63811842d0a5.sites.pages.cloud.gov/demo/gsa/oasis-plus/oasis-plus/events-training/

ekidenda commented 4 months ago

@weiwang-gsa the page looks good and links are working as expected. Moving it to done.