search

GSA / openacr

OpenACR is a digital native Accessibility Conformance Report (ACR). The initial development is based on Section 508 requirements. The main goal is to be able to compare the accessibility claims of digital products and services. A structured, self-validated, machine-readable documentation will provide for this.
https://gsa.github.io/openacr/
Other
83 stars 18 forks source link

File upload of YAML files on chromebook doesn't work #339

Closed dmundra closed 2 years ago

dmundra commented 2 years ago

@mgifford discovered that upload of YAML files on a chromebook does not seem to work. We cannot figure out what the mime-type is either and this line https://github.com/GSA/openacr-editor/blob/main/src/utils/importEvaluation.js#L13 doesn't give an error so that can be improved as well.

mgifford commented 2 years ago

This is clearly an upstream bug... That said, it is an annoying one.

You found a similar issue on in the Chrome bug tracker, right? Best to link to that here I think (even if it isn't quite right).

dmundra commented 2 years ago

@mgifford not sure if https://bugs.chromium.org/p/chromium/issues/detail?id=342554 is relevant as it is pretty old. Should we allow the file to go through based on file extension? That seems like the one workaround for now.

mgifford commented 2 years ago

If there is no mime type, let's default to the extension to determine the file type. That seems like the best approach until Google gives us access root access to their repo...

dmundra commented 2 years ago

@mgifford I pushed up a change to the PR. Can you try it again on your chromebook and see if it works now?