search

GSA / piv-guides

This is the old location for the PIV Playbook. New location below.
https://playbooks.idmanagement.gov/piv/
Other
69 stars 44 forks source link

Add 3rem margin-bttom to Alert box #146

Closed godadada closed 7 years ago

godadada commented 7 years ago

The issue was there is no space between bottom of alert box and following content, looking crammed in rendering. The solution is to add 3 rem margin-bottom to class usa-alert. The change will impact all md documents that have Alert box; We need to watch for regression in existing document rendering.

djpackham commented 7 years ago

@godadada before we actually merge, can you verify adding this CSS change doesn't affect the other pages? Without taking a look myself, I think it may add quite a large space between alert boxes and paragraph elements.

godadada commented 7 years ago

We made it better. I am comparing ID Management page without the added CSS change and my Jekyll with new CSS. e.g. page https://piv.idmanagement.gov/networkconfig/accounts/ old (ID Management): [image: Inline image 2]

new (my Jekyll): [image: Inline image 1]

On Fri, Jun 16, 2017 at 12:33 PM, Jordan Packham notifications@github.com wrote:

@godadada https://github.com/godadada before we actually merge, can you verify adding this CSS change doesn't affect the other pages? Without taking a look myself, I think it may add quite a large space between alert boxes and paragraph elements (i.e.

).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GSA/piv-guides/pull/146#issuecomment-309073193, or mute the thread https://github.com/notifications/unsubscribe-auth/AFzj9PTC_eXZNHx-wzx0pemCI8IUcJjwks5sEq51gaJpZM4N8Ux9 .

-- Regards, Chunde Shi