search

GSA / piv-guides

This is the old location for the PIV Playbook. New location below.
https://playbooks.idmanagement.gov/piv/
Other
69 stars 44 forks source link

Issue50 Network-Tuning #166

Closed godadada closed 7 years ago

godadada commented 7 years ago

This is a PR for network-tuning.md.

lachellel commented 7 years ago

@godadada there are conflicts in this PR

In addition, there are commits for the same files into different branches. For example, nss, ama and crl markdown files are in this commit to this branch.

Do you want to use one branch to iterate on all four areas? Or four different branches? If it's four different branches, then this branch (network-tuning) only needs to contain the changes / files for network tuning!

godadada commented 7 years ago

Each branch should have one issue. More than one issue were included in one branch was a mistake. I should have fork from a source that does not contain other issues when targeting one issue.

On Sat, Jul 15, 2017 at 10:36 AM, LRL notifications@github.com wrote:

@godadada https://github.com/godadada there are conflicts in this PR

In addition, there are commits for the same files into different branches. For example, nss, ama and crl markdown files are in this commit to this branch.

Do you want to use one branch to iterate on all four areas? Or four different branches? If it's four different branches, then this branch (network-tuning) only needs to contain the changes / files for network tuning!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GSA/piv-guides/pull/166#issuecomment-315537999, or mute the thread https://github.com/notifications/unsubscribe-auth/AFzj9BdC51FZs_DK24_PAhSDdbTFBrSfks5sOM5YgaJpZM4OY3sh .

-- Regards, Chunde Shi