search

GSA / project-open-data-dashboard

Project Open Data Dashboard
http://labs.data.gov/dashboard/
Other
138 stars 119 forks source link

Mock redirects to avoid dependency on external service #368

Closed mogul closed 2 years ago

mogul commented 2 years ago

redir.xpoc.pro is no longer available and tests that previously passed were failing, so we did the work to be able to mock out our calls to the curl library and run our tests without any external dependences.

mogul commented 2 years ago

Although this is passing now, it's only because I put in a workaround for weird behavior in the curl wrapper class method for curl_getinfo(). You only see it when you're not mocking that class.

Also there're a couple upstream fixes for bugs I encountered in the wrapper class.

You'll notice that tests are passing despite an error being thrown; which is just a coincidence. I'll make the composer.json point to my fork, which has those fixes integrated in another commit to this branch, then remove the draft status.