Underscores in URL return invalid URL format

GSA / project-open-data-dashboard

Project Open Data Dashboard

http://labs.data.gov/dashboard/

Other

138 stars 119 forks source link

Underscores in URL return invalid URL format #82

Open dafeder opened 9 years ago

dafeder commented 9 years ago

We are trying to validate DKAN's 1.1 implementation and keep getting failures. As far as we can tell the only thing triggering them is underscores in our URLs.

http://labs.data.gov/dashboard/validate?schema=federal-v1.1&output=browser&datajson_url=http%3A%2F%2Ftesting_pod_1_1.dkan.qa.nuamsdev.com%2Fdata.json&qa=true

dafeder commented 9 years ago

I see the source of this issue, the validator uses PHP's filter_var(), which considers underscores invalid in domain names. See:

https://bugs.php.net/bug.php?id=64948

This was just a temporary testing site so in this case we can use a different subdomain naming scheme, but could imagine this causing problems for some data publishers.