Adopting GSA's Error Identification

angelina-smith commented 5 months ago

What's expected

Feedback from GSA accessibility audit team

See success criteria 3.3.3. The error message should say what was not filled out and link them to that form section to complete the form. Reference: USAGov's error handling at: https://www.usa.gov/elected-officials#input-street.

What happened

On the About the application page using NVDA the user does not select a Marital Status the error message only says that all fields are required but does not say what was missed.

From AT UT sessions:

When user makes an error in the Year field alone, the Month and Day fields are also flagged as being invalid.

How to replicate

Create an error by leaving required fields empty or making a mistake in memorable date.

angelina-smith commented 5 months ago

@fongcindy I know this touches on multiple practice areas and will require more conversation. However, this is something the GSA a11y team and our accessibility team should be implement as it addresses multiple accessibility failures. (I also feel like all of the feedback from our AT UT sessions supports the need for our improved error identification/handling)

ErnestoFernandezAlvarez commented 5 months ago

@Cindy Fong - QQBC-C @.> @Angelina Smith - QQBC-C @.> I wanted to mention that USA.gov has a preferred way of doing error messages. We briefly addressed Error Messages during their design feedback sessions. I think when we get to this stage we should regroup and look into this in detail (devs, usa.gov, a11y, design). Coming off the AT sessions, I thought this feature was the most problematic.

On Wed, Mar 27, 2024 at 5:10 PM Angelina Smith @.***> wrote:

@fongcindy https://github.com/fongcindy I know this touches on multiple practice areas and will require more conversation. However, this is something the GSA a11y team and our accessibility team should be implement as it addresses multiple accessibility failures. (I also feel like all of the feedback from our AT UT sessions supports the need for our improved error identification/handling)

— Reply to this email directly, view it on GitHub https://github.com/GSA/px-benefit-finder/issues/1121#issuecomment-2023875565, or unsubscribe https://github.com/notifications/unsubscribe-auth/A54BNY33WFOC2SYOGYYIUADY2MRS3AVCNFSM6AAAAABFLRXCHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTHA3TKNJWGU . You are receiving this because you were assigned.Message ID: @.***>

angelina-smith commented 4 months ago

History and context for where this ticket comes from: Both the feedback from all AT UT sessions and USAgov's accessibility audit in early Jan shows that we need to adopt USAgov's error identification.

ErnestoFernandezAlvarez commented 4 months ago

Very helpful.

On Fri, May 10, 2024 at 10:16 AM Angelina Smith @.***> wrote:

History and context for where this ticket comes from: Both the feedback from all AT UT sessions and USAgov's accessibility audit in early Jan shows that we need to adopt USAgov's error identification.

— Reply to this email directly, view it on GitHub https://github.com/GSA/px-benefit-finder/issues/1121#issuecomment-2104789901, or unsubscribe https://github.com/notifications/unsubscribe-auth/A54BNYZO35YPJAXKW4CL5T3ZBTQGDAVCNFSM6AAAAABFLRXCHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUG44DSOJQGE . You are receiving this because you were assigned.Message ID: @.***>

fongcindy commented 3 months ago

@ErnestoFernandezAlvarez No prototype or design is needed for this for now, Angelina's screenshot above is enough.

Next step: @scottqueen-bixal to see how far he can fix on his end without design for now, will keep us posted. Planned for sprint 34

ErnestoFernandezAlvarez commented 3 months ago

Hi team @scottqueen-bixal @fongcindy @angelina-smith @erniedeeb

Please note that there isn't design's input on this ticket at the moment. Cindy confirmed Scott will be handing this ticket. If there is a need from design I will be notified. Thank you!

ErnestoFernandezAlvarez commented 3 months ago

Sounds good, thanks!

On Tue, May 14, 2024 at 1:50 PM Cindy Fong @.***> wrote:

@ErnestoFernandezAlvarez https://github.com/ErnestoFernandezAlvarez No prototype or design is needed for this for now, Angelina's screenshot above is enough.

Next step: Scott to see how far he can fix on his end without design for now, will keep us posted.

— Reply to this email directly, view it on GitHub https://github.com/GSA/px-benefit-finder/issues/1121#issuecomment-2110914661, or unsubscribe https://github.com/notifications/unsubscribe-auth/A54BNY2XXLWQMSTGQIBX663ZCJMGTAVCNFSM6AAAAABFLRXCHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHEYTINRWGE . You are receiving this because you were mentioned.Message ID: @.***>

scottqueen-bixal commented 2 months ago

I've broken this up into three workable issues

Include additional text to resolve form field errors with fields https://github.com/GSA/px-benefit-finder/issues/1513 Include a list of links to the fields that have errors in alerts https://github.com/GSA/px-benefit-finder/issues/1512 Include error count in alert https://github.com/GSA/px-benefit-finder/issues/1511

scottqueen-bixal commented 1 month ago

This work was pushed to sprint 37 to prioritize work on the dataLayer

GSA / px-benefit-finder